Fix: オフライン時に大室櫻子が出てこない #5480
Merged
Fix: オフライン時に大室櫻子が出てこない #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
onerrorでインターネットから取得に切り替えるとか |
|
clientのboot.jsとかその辺で一度fetchしておくとか |
|
onerrorにしました |
|
ありがとうございます👍👍👍 |
mei23
added a commit
to mei23/misskey
that referenced
this pull request
Oct 6, 2019
* Fix: オフライン時に大室櫻子が出てこない * use onerror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PWA等でオフライン時のエラー画像が
ローカルassetsにあってServiceWorkerキャッシュにも入れてるにもかかわらず
リンク先がリモートなので表示されないのを修正
https://github.com/syuilo/misskey/blob/96b88ee369bc6d6d5510b0df96b96fb08088268f/src/client/app/sw.js#L20-L25
でもこれをやると、非PWAで該当サーバーだけがオフラインでSWのキャッシュに画像がない場合は
表示されなくなりそうだからどうしよう。
Data-URIが良さそうだけど過去にやっててやめた跡があるし