Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

投稿のURLプレビューポップアップを改良 #6226

Merged
merged 3 commits into from Apr 13, 2020
Merged

投稿のURLプレビューポップアップを改良 #6226

merged 3 commits into from Apr 13, 2020

Conversation

tamaina
Copy link
Member

@tamaina tamaina commented Apr 6, 2020

  • タッチデバイスでは表示しないように
  • 幅をレスポンシブに

タッチデバイスでスクロールが表示されてうざいのを修正。
結構大きいバグだと思うけど該当Issueを発見できなかった…

@tamaina
URLプレビューポップアップを改良
fcd3dcd 
- タッチデバイスでは表示しないように
- 幅をレスポンシブに
@tamaina tamaina requested a review from syuilo April 6, 2020 14:13
@syuilo
Copy link
Member

syuilo commented Apr 11, 2020

('ontouchstart' in window) で良いのか気になっている

@tamaina
Copy link
Member Author

tamaina commented Apr 11, 2020

https://stackoverflow.com/questions/4817029/whats-the-best-way-to-detect-a-touch-screen-device-using-javascript
このあたり？

@acid-chicken
Copy link
Member

navigator.maxTouchPoints で取れると思う

@tamaina
Copy link
Member Author

tamaina commented Apr 11, 2020

navigator.maxTouchPoints > 0?

@acid-chicken
Copy link
Member

> 0 つけてもまあ意味的には変わらない（タッチポイントがないデバイスは 0 が返って falsy だし）

@tamaina
Copy link
Member Author

tamaina commented Apr 11, 2020

navigator.maxTouchPointsで判断するようにした

@syuilo syuilo merged commit 96eab7e into misskey-dev:develop Apr 13, 2020
@syuilo
Copy link
Member

syuilo commented Apr 13, 2020

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tamaina @syuilo @acid-chicken