feat: Observe notification read and fix #6406 #6407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tamaina
commented
May 24, 2020
•
tamaina
commented
- https://github.com/syuilo/misskey/pull/6406#issuecomment-633203670 の修正
- notificationのpack（=APIの通知の返答）でisReadを含めるように
- 通知一覧で、通知が画面に表示されると既読にすなるように（IntersectionObserver使用）
- String Unionをsrc/types.tsにまとめる
|
通知ウィジェットを表示していたり通知ページにいた場合、既読をつける処理をしないとだ |
|
notificationのPack時にisReadがなくて、各通知の既読状態を知る手立てがないんだよね。含めるようにしちゃっていいかしら？ |
tamaina
requested review from
mei23,
syuilo and
acid-chicken
and removed request for
mei23 and
syuilo
|
post-form.vueが #6408 と競合した |
|
通知表示検出もc2.a9z.devで動作中 |
|
isRead: falseな通知がAPIから返ってくるケースってあるかな？ |
|
ストリームからきた通知はfalseなのでそこらへんで |
|
isReadが最初からfalseなときはIntersectionObserverのインスタンスは無駄ですね |
|
これ、メンションなどのnoteの場合は既読にならないですね |
syuilo
reviewed
Jun 3, 2020
syuilo
reviewed
Jun 3, 2020
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
syuilo
reviewed
Jun 4, 2020
| @@ -0,0 +1,3 @@ | |||
| export const notificationTypes = ['follow', 'mention', 'reply', 'renote', 'quote', 'reaction', 'pollVote', 'receiveFollowRequest', 'followRequestAccepted', 'groupInvited', 'app'] as const; | |||
There was a problem hiding this comment.
notificationTypes は src/models/entities/notification にあっても良さそうに思った
syuilo
reviewed
Jun 4, 2020
| @@ -0,0 +1,3 @@ | |||
| export const notificationTypes = ['follow', 'mention', 'reply', 'renote', 'quote', 'reaction', 'pollVote', 'receiveFollowRequest', 'followRequestAccepted', 'groupInvited', 'app'] as const; | |||
|
|
|||
| export const noteVisibilities = ['public', 'home', 'followers', 'specified'] as const; | |||
There was a problem hiding this comment.
noteVisibilities は src/models/entities/note にあっても良さそう
|
クライアントで使用する場合にmodels/entitiesにあるtsから持ってきても大丈夫なのでしょうか？ 怖いけど適当な場所がなかったのでtypes.tsを作ったのですが |
|
うーむ |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.