Fix channels list pagination #6679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
トレンド/フォロー中/管理中のチャンネル数がそれぞれ6件以上になると同じ項目が2度以上出現する問題を修正しました。
原因はクライアント側ではページネーションをしようと limit と untilId をつけてリクエストしますが、サーバーがそれらを無視して全件レスポンスしていたためです。
トレンド (featured) は必ず10件までのためページネーションは必要無いと判断して無効化、フォロー中と管理中のチャンネルについては5件単位でページネーションされるようにしました。