Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blacklist for notification filtering #6703

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Use blacklist for notification filtering #6703

merged 1 commit into from
Sep 18, 2020

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 17, 2020

Summary

Resolve #6692

@syuilo
Copy link
Member Author

syuilo commented Sep 17, 2020

内部的にはブラックリストになったけど、UIの設定画面上では引き続きホワイトリストになっています。

EbiseLutica
EbiseLutica approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@EbiseLutica EbiseLutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既に設定されたものについては削除されてしまいそうですが、それはノータッチで良さそうですかね

@syuilo
Copy link
Member Author

syuilo commented Sep 17, 2020

「再設定してください」で良い気はしている

@syuilo syuilo merged commit df71dbb into develop Sep 18, 2020
@syuilo syuilo deleted the use-blacklist-for-notification-filtering branch September 18, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbiseLutica EbiseLutica EbiseLutica approved these changes

@mei23 mei23 mei23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

通知設定をホワイトリスト制ではなくブラックリスト制にする
3 participants
@syuilo @EbiseLutica @mei23