Fix avatar/banner proxy #8346
Merged
Fix avatar/banner proxy #8346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mei23 <m@m544.net>
|
例のごとくp1.a9z.devで試験中 |
syuilo
reviewed
Feb 23, 2022
Comment on lines
213
to
214
| if (src.avatar === undefined && src.avatarId) src.avatar = await DriveFiles.findOne(src.avatarId) || null; | ||
| if (src.banner === undefined && src.bannerId) src.banner = await DriveFiles.findOne(src.bannerId) || null; |
There was a problem hiding this comment.
タイムラインとか取得する場合だとクエリの数が結構増えてしまいそう
クエリのレイテンシが遅くて20ms程度ある環境を考えると 20 * 2(avatar, banner) * 2(リプライとか引用先のユーザー) * 10(タイムラインの投稿の数) = 800 でAPIのレスポンスが一秒くらい遅くなりそう
There was a problem hiding this comment.
プロキシの設定はそんなに頻繁に変わらないと思うから長めにキャッシュしても良さそう
There was a problem hiding this comment.
タイムラインAPIから呼ばれた時はsrc.avatarが既に入ってる前提だった気がする（覚えてない）
There was a problem hiding this comment.
いやしてない。タイムラインクエリで User.avatar => DriveFile にJOINしないといけない。
|
/avatarの動作を変える必要がある |
|
いやないか？ |
|
うまく動いていなさそう
|
|
TypeORMわからん |
|
引き継ぐわ |
|
とりあえずタイムライン系のAPIでJOINするようにした |
直した |
|
🙏🏻🙏🏻🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7601
Fix #7602
#7767 を復活