fix: keep file order

[Johann150]

What

The file IDs are used in the order they are sent.

When using the IN operator, the database will return the files in the order they are stored on disk, which is usually the order they were inserted in. That explains why attachments were always ordered by file ID as noted in the issue.

To keep the advantage of having a single database query, I modified the query to add an order by clause instead of partly reverting 9f7cdb4 which would have meant multiple queries. This should keep any improved performance.

Why

fix #8647

[syuilo]

👍🏻👍🏻👍🏻

[tamaina]

function array_position(text[], character varying) does not exist が出た

[Johann150]

It worked for me 😬 Which version of postgres are you using? Can you try if it works if you cast the id to the same type with `"id"::text`?

[absturztau-be]

same happened to me. resulted into not being able to post notes with attachments and it slowed down drive too

psql version 13.5 for me

according to the psql docs, it should be part of it too

https://www.postgresql.org/docs/13/functions-array.html

Can you try if it works if you cast the id to the same type with "id"::text?

haven't tested this yet

[absturztau-be]

changing the query to array_position(ARRAY[<whatever>], "id"::text) seems to work on psql 13.5

[tamaina]

I use 13.7.

@Johann150 Which version are you using?

Can you try if it works if you cast the id to the same type with "id"::text?

haven't tested this yet

[Johann150]

Ah, my testing environment used Postgres 14.2, so I was using the wrong version of Postgres. My mistake 🙇

[Johann150]

Thanks for catching this, has been fixed on develop.