Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(federation): use ActivityPub defined property in favour of proprietary property. #8787

Merged
merged 2 commits into from Jun 10, 2022

Conversation

Johann150
Copy link
Contributor

What

Add ActivityPub source property.

For now this continues to write and read the _misskey_content property. This change is therefore fully backward compatible.

Why

related to #8785. This PR does not completely fix that issue yet: The _misskey_content attribute should be removed in the future. I think we should wait at least 3 months after initial release of this change before removing _misskey_content.

@Johann150 Johann150 added packages/backend Server side specific issue/PR 🌌Federation The Federation/ActivityPub feature labels Jun 5, 2022
@tamaina tamaina requested a review from syuilo June 7, 2022 07:23
@tamaina
Copy link
Member

tamaina commented Jun 7, 2022

p1.a9z.devに適用してみた

@syuilo syuilo merged commit a683a70 into misskey-dev:develop Jun 10, 2022
@syuilo
Copy link
Member

syuilo commented Jun 10, 2022

👍🏻

@syuilo syuilo mentioned this pull request Jun 10, 2022
@Johann150 Johann150 deleted the federation-source branch June 10, 2022 06:01
@CosmicToast
Copy link
Contributor

you could/should probably use json-ld contexts to provide the migration path via aliases

Johann150 added a commit that referenced this pull request Jun 16, 2022
Fix a regression from #8787 that was previously fixed in #8440.
Jeder321 pushed a commit to Jeder321/misskey that referenced this pull request Jul 13, 2022
Fix a regression from misskey-dev#8787 that was previously fixed in misskey-dev#8440.
nullobsi pushed a commit to nullobsi/misskey that referenced this pull request Feb 14, 2023
As already noted back in misskey-dev#8787
the intention was to replace the `_misskey_content` attribute with the
ActivityPub-defined `source` property. Misskey and by extension Foundkey
have shipped with the `source` property and the respective parsing for
quite a while so it seems reasonable to remove it now.

Changelog: Removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants