Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Broken chats #8951

Closed
wants to merge 2 commits into from
Closed

fix(client): Broken chats #8951

wants to merge 2 commits into from

Conversation

ltlapy
Copy link
Contributor

@ltlapy ltlapy commented Jul 6, 2022 •
edited

What & Why

Additional info (optional)

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 6, 2022
@ltlapy ltlapy changed the title fix(client): fix(client): Broken chats Jul 6, 2022
@ltlapy ltlapy marked this pull request as draft July 6, 2022 12:38
@ltlapy ltlapy marked this pull request as ready for review July 6, 2022 12:55
@ThatOneCalculator
Copy link
Contributor

ThatOneCalculator commented Jul 6, 2022 •
edited

New messages come in live BUT it erases the prev message. Testing on https://stop.voring.me

@ThatOneCalculator
Copy link
Contributor

ThatOneCalculator commented Jul 6, 2022 •
edited

Also there seems to be some weird overlapping problems
Screenshot_20220706-080513.png

This is unscrolled.

Screenshot_20220706-080645_1.png

Johann150
Johann150 reviewed Jul 6, 2022
View reviewed changes
packages/client/src/pages/messaging/messaging-room.vue
@@ -292,6 +292,7 @@ definePageMetadata(computed(() => !fetching ? user ? {
<style lang="scss" scoped>
.mk-messaging-room {
position: relative;
overflow: scroll;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using overflow-y here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling.

Or maybe use overflow: auto; instead to let the browser decide when scroll bars are necessary.

@ThatOneCalculator
Copy link
Contributor

The problem of messages being cut off only seems to happen on mobile. Works fine on desktop.

@ltlapy ltlapy marked this pull request as draft July 8, 2022 14:51
@ltlapy
Copy link
Contributor Author

ltlapy commented Jul 8, 2022

I think i'm cannot handle with these problems, those are more complicated than i thought.
Thanks to feedbacks, and Sorry for late replying.

@ltlapy ltlapy closed this Jul 8, 2022
@ThatOneCalculator
Copy link
Contributor

I think i'm cannot handle with these problems, those are more complicated than i thought.
Thanks to feedbacks, and Sorry for late replying.

I don't think it should be too hard to fix, just a tiny bit of positioning. If you re-open this PR I'd be happy to take a look and see if I can make a solution :)

This was referenced Jul 11, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann150 Johann150 Johann150 left review comments

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending a chat doesn't show the message you sent until reloading a page
3 participants
@ltlapy @ThatOneCalculator @Johann150