Fastify #9106
Fastify #9106
Conversation
|
tasukete |
|
@syuilo I managed to fix this issue by extracting "actual" values from multipart fields (ycanardeau@e8fab4a), although I'm not sure if this is the right way to fix it. |
| const [path] = await createTemp(); | ||
| await pump(multipartData.file, fs.createWriteStream(path)); | ||
|
|
||
| const token = multipartData.fields['i']; |
There was a problem hiding this comment.
The problem is that the multipartData.fields property returns an object like this:
{
i: {
fieldname: 'i',
mimetype: 'text/plain',
value: /* ... */,
// ...
},
force: {
fieldname: 'force',
mimetype: 'text/plain',
value: 'true',
// ...
},
file: {
fieldname: 'file',
filename: 'blob',
mimetype: /* ... */,
file: /* ... */,
// ...
},
name: {
fieldname: 'name',
mimetype: 'text/plain',
value: /* ... */,
// ...
}
}The extractMultipartFields method converts this object into the following format:
{
i: /* ... */,
force: 'true',
file: undefined,
name: /* ... */
}However, one of the problems of the extractMultipartFields method is that it contains file: undefined, which does not exist on koa's equivalent. I'm not sure if this would be a problem though.
|
Re: https://misskey.io/notes/989o0zrglu @syuilo I was experiencing exactly the same issue on Windows 11 when I merged the latest commit from 7b563c1. I just deleted |
|
型が付かないのはなぜ？ |
|
ここも |
|
tasukete |
|
https://p1.a9z.dev/queue なくなった？ |
|
あー忘れてた |
|
既知の問題: inboxがお亡くなりになってる |
|
inboxはエラーも出てない |
This reverts commit 3a7182b.
This reverts commit 3a7182b.
|
謎 |
|
てか逆にこれが効いたとすると、すべてのfastifyインスタンスのReplyにsendFileが生えてることになっちゃわない？(実際はプラグインを明示的にregisterしたインスタンスだけに生える) |
|
:tasukete: |
This reverts commit cfe148b.
What
Resolve #7537
Why
Additional info (optional)