fix: 一部の状態のファイルをドロップしてアップロードできない場合がある問題を修正 (投稿フォーム以外についても) #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 |
Jeder321
pushed a commit
to Jeder321/misskey
that referenced
this pull request
Nov 21, 2022
* Fixed association between dropEffect and effectAllowed as well as the submission form * Fixed that strings can be dropped Reviewed-on: misskey-dev#9114 Changelog: Fixed
yu256
pushed a commit
to yu256/akatsukey
that referenced
this pull request
Mar 5, 2023
…ev#9114) * dropEffectとeffectAllowedの関連付けを投稿フォームと同様に修正 * 文字列をDropできるようにしてしまったのを修正
morotesovtannu
pushed a commit
to ganngi-mari/missnemone
that referenced
this pull request
Jan 20, 2024
…ev#9114) * dropEffectとeffectAllowedの関連付けを投稿フォームと同様に修正 * 文字列をDropできるようにしてしまったのを修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#9035 で変更した箇所に漏れがあった: ドライブ、メッセージのファイルをドロップできる部分についても同様に修正した
具体的には、
effectAllowedがallでないときにも基本的にcopyを使用するようにし、moveしか受けつけない条件でのみmoveを使用するようにした (#9035 と同じ内容) 。Why
例えばアプリケーションから直接書き出されたファイルのような、「移動することはできないがコピーすることができる」状態のファイルがドロップされた場合、
move操作は拒否され、結果として、ファイルはアップロードされない。