Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): request.body may be undefined #9356

Merged
merged 1 commit into from Dec 19, 2022

Conversation

saschanaz
Copy link
Member

What

Fix backend assuming POST body always exists

Why

Because cypress was throwing Cannot read properties of undefined (reading 'i') before #9355. This can easily be reproduced by curl -X POST http://localhost:61812/api/reset-db.

Additional info (optional)

Forgot to push this one to #9355.

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #9356 (a117c6b) into develop (72e7909) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #9356   +/-   ##
========================================
  Coverage    22.43%   22.43%           
========================================
  Files          702      702           
  Lines        65727    65727           
  Branches      2126     2126           
========================================
  Hits         14743    14743           
  Misses       50984    50984           
Impacted Files Coverage Δ
packages/backend/src/server/api/ApiCallService.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit c3cb218 into misskey-dev:develop Dec 19, 2022
@syuilo
Copy link
Member

syuilo commented Dec 19, 2022

👍

@saschanaz saschanaz deleted the fix-backend branch December 19, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants