Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dev mode #9640

Merged
merged 2 commits into from Jan 21, 2023
Merged

Fix for dev mode #9640

merged 2 commits into from Jan 21, 2023

Conversation

CyberRex0
Copy link
Contributor

@CyberRex0 CyberRex0 commented Jan 17, 2023

What

pnpm dev (開発モード)が動作しない問題を修正する。

・chokidarを3.3.1 → 3.5.3 にアップグレード。これによりApple Siliconにも対応し、最新のNodeにも対応する。
・frontendのwatchコマンド実行時、viteをただ起動するだけになっていたのを修正
・scripts/dev.jsでgulpを呼び出す方法を修正。
 インストール状態に依らずその場でダウンロードして使う? dlx から、インストールされたものを使う exec に修正

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #9640 (b7ad05f) into develop (d456308) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #9640   +/-   ##
========================================
  Coverage    22.62%   22.62%           
========================================
  Files          731      731           
  Lines        68487    68487           
  Branches      2028     2028           
========================================
  Hits         15495    15495           
  Misses       52992    52992           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Member

tamaina commented Jan 17, 2023

watchコマンド実行時、viteをただ起動するだけになっていたのを修正

これは正常な動作というかこれで正しく動くはずというかこうしなければならないんだけど

@CyberRex0
Copy link
Contributor Author

CyberRex0 commented Jan 17, 2023

開いてもNot Foundになるのはviteの引数のせいではなくてgulpが悪かったのかもしれない(gulpがエラーで止まってたので

packages/frontend/package.json Outdated Show resolved Hide resolved
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
@github-actions github-actions bot removed the packages/frontend Client side specific issue/PR label Jan 17, 2023
@tamaina tamaina merged commit bd3d75d into misskey-dev:develop Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants