Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Refactor MkPageHeader #9869 #9878

Merged
merged 5 commits into from
Feb 11, 2023
Merged

Conversation

tamaina
Copy link
Member

@tamaina tamaina commented Feb 11, 2023

What

  1. MkPageHeaderのタブをMkPageHeader.tabsに分離
  2. animation設定をフォローするように

Why

  1. 同じことを2回書いていたため
  2. タブのアニメーションはそこそこ重たい処理のため

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 11, 2023
@tamaina tamaina merged commit 9349f72 into develop Feb 11, 2023
@tamaina tamaina deleted the page-header-2 branch February 11, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant