Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 削除済みのユーザーが deleteActor される時に処理をスキップする #9980

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

xianonn
Copy link
Contributor

@xianonn xianonn commented Feb 18, 2023

What

ActivityPub でユーザーの削除を受信してユーザーの削除済みフラグを立てる処理をする際、既にそのユーザーの削除済みフラグが立っている場合に正しくスキップするようになる。

Why

スキップするログが残るようになっているが実際にはスキップされていないため。

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #9980 (e731ec3) into develop (8c88365) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #9980   +/-   ##
========================================
  Coverage    23.14%   23.14%           
========================================
  Files          699      699           
  Lines        64785    64785           
  Branches      1984     1984           
========================================
  Hits         14995    14995           
  Misses       49790    49790           
Impacted Files Coverage Δ
...ges/backend/src/core/activitypub/ApInboxService.ts 18.51% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit b055f51 into misskey-dev:develop Feb 20, 2023
@syuilo
Copy link
Member

syuilo commented Feb 20, 2023

🙏🏻

@xianonn xianonn deleted the xianon-fix-skip-delete-actor branch February 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants