Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(backend): restore AP unit tests #9987

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Conversation

saschanaz
Copy link
Member

What

ActivityPub unit testの復活

Why

Nest+Jestえの移行以来(b75184e)ずっと捨てられていたので

Additional info (optional)

#9970 のための準備です

@github-actions github-actions bot added packages/backend Server side specific issue/PR 🧪Test labels Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #9987 (ea119b3) into develop (8c88365) will increase coverage by 1.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #9987      +/-   ##
===========================================
+ Coverage    23.14%   24.45%   +1.30%     
===========================================
  Files          699      699              
  Lines        64785    64785              
  Branches      1984     2240     +256     
===========================================
+ Hits         14995    15842     +847     
+ Misses       49790    48943     -847     
Impacted Files Coverage Δ
...ges/backend/src/core/entities/NoteEntityService.ts 20.28% <0.00%> (+1.20%) ⬆️
...ackages/backend/src/models/entities/UserProfile.ts 100.00% <0.00%> (+2.04%) ⬆️
packages/backend/src/models/entities/Note.ts 100.00% <0.00%> (+2.05%) ⬆️
packages/backend/src/models/entities/User.ts 100.00% <0.00%> (+2.14%) ⬆️
...ges/backend/src/core/entities/UserEntityService.ts 33.39% <0.00%> (+2.53%) ⬆️
...end/src/core/entities/NotificationEntityService.ts 33.33% <0.00%> (+2.66%) ⬆️
packages/backend/src/core/AntennaService.ts 36.03% <0.00%> (+3.60%) ⬆️
packages/backend/src/logger.ts 69.81% <0.00%> (+3.77%) ⬆️
packages/backend/src/misc/prelude/array.ts 57.24% <0.00%> (+4.34%) ⬆️
packages/backend/src/core/HashtagService.ts 26.20% <0.00%> (+5.51%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saschanaz
Copy link
Member Author

ミスキー寄与以来初のcoverageアップ

@syuilo syuilo merged commit 2aa73fd into misskey-dev:develop Feb 19, 2023
@syuilo
Copy link
Member

syuilo commented Feb 19, 2023

🙏🏻🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants