Fix measure.c memory leak and warnings/errors with newer gcc/glibc and vc++ #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a memory leak in measure.c
|
Nice, builds clean on gcc9 and gcc10. This would fix #9 |
|
This pull request also fixes an unreported massive memory leak in measure.c, resetChip_test(). This fact should be made more prominent. Or should the error be reported to catch the developer's attention? Edit: Oh, I see rheit has mentioned it in the first sentence. Still, it is an important fix, but it’s all too easy to skim over it. |
rheit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes warnings from gcc and glibc that prevent compilation with -Werror, updates apple1basic.c to the new API, fixes the #ifdef _WIN32 block in that file, and fixes a memory leak in measure.c.
I fixed the Makefile issue by creating a single Makefile that can build cbmbasic, apple1basic, and measure all at once or individually. However, since this changes the Makefile system from three files to one, I left it out of this pull request. If desired, I could add that. The other alternative is to comment out the OBJS+=measure.o line again.