Skip to content

Commit

Permalink
feature: add rule name for better error report
Browse files Browse the repository at this point in the history
  • Loading branch information
mistlog committed Jan 16, 2021
1 parent eee962e commit 2925441
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "react-peg",
"version": "0.1.4",
"version": "0.1.5",
"description": "A react style parser generator, based on PEG.js",
"keywords": [
"react",
Expand Down
3 changes: 3 additions & 0 deletions src/renderer/__snapshots__/renderer.test.tsx.snap
@@ -0,0 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`renderer.parse 1`] = `"Expected Digit but \\"a\\" found."`;
2 changes: 1 addition & 1 deletion src/renderer/renderer.test.tsx
Expand Up @@ -22,7 +22,7 @@ test("renderer.parse", () => {
const parser = ReactPeg.render(<Digit />);
expect(() => {
parser.parse("a")
}).toThrow();
}).toThrowErrorMatchingSnapshot();
})


Expand Down
10 changes: 7 additions & 3 deletions src/translator/rule/__snapshots__/rule.test.tsx.snap
@@ -1,15 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`translator.rule.label 1`] = `"Test = l: (a: (c: 'a' / t: 'b'))+"`;
exports[`translator.rule 1`] = `"Test \\"Test\\" = 'abc'"`;

exports[`translator.rule.label 1`] = `"Test \\"Test\\" = l: (a: (c: 'a' / t: 'b'))+"`;

exports[`translator.rule.pattern 1`] = `"Test \\"Test\\" = Foo"`;

exports[`translator.rule.props 1`] = `
"Char = ([A-Z] {
"Char \\"Char\\" = ([A-Z] {
return actions.get(\\"action0\\")({globalFunction});
})"
`;

exports[`translator.rule.props 2`] = `
"Char = ([a-z] {
"Char \\"Char\\" = ([a-z] {
return actions.get(\\"action0\\")({globalFunction});
})"
`;
4 changes: 2 additions & 2 deletions src/translator/rule/rule.test.tsx
Expand Up @@ -9,7 +9,7 @@ test("translator.rule", () => {
}
const chunk = <Test />;
const rule = new RuleTranslator().translate(chunk);
expect(rule).toEqual(`Test = 'abc'`);
expect(rule).toMatchSnapshot();
})


Expand Down Expand Up @@ -48,7 +48,7 @@ test("translator.rule.pattern", () => {

const chunk = <Test />;
const rule = new RuleTranslator().translate(chunk);
expect(rule).toEqual(`Test = Foo`);
expect(rule).toMatchSnapshot();

})

Expand Down
2 changes: 1 addition & 1 deletion src/translator/rule/rule.ts
Expand Up @@ -22,7 +22,7 @@ export class RuleTranslator extends Translator {
this.cache.rule = chunkInput.rule;

//
const rule = `${name} = ${pattern}`;
const rule = `${name} "${name}" = ${pattern}`;
return rule;
}
}

0 comments on commit 2925441

Please sign in to comment.