bugfix: keep default value in method addition

mistlog · Aug 15, 2020 · e464eea · e464eea
1 parent eafb0f8
commit e464eea
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/src/code-object/method.tsx b/src/code-object/method.tsx
@@ -55,7 +55,12 @@ export class Foo {
         /**
          * remove param "this":
          */
-        const params = raw_params.filter(param => isIdentifier(param) && param.name !== "this");
+        const params = raw_params.filter(param => {
+            if (isIdentifier(param) && param.name === "this") {
+                return false;
+            }
+            return true;
+        });
         const kind = id.name === "constructor" ? id.name : "method";
 
         const class_method = classMethod(kind, id, params, body);

diff --git a/test/code-object/__snapshots__/method.test.ts.snap b/test/code-object/__snapshots__/method.test.ts.snap
@@ -1,5 +1,11 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`method default value 1`] = `
+"Test(a: number, b: string = \\"\\") {
+  return a.toString() + b;
+}"
+`;
+
 exports[`method to class method 1`] = `
 "Test(a: number, b: string) {
   return a.toString() + b;

diff --git a/test/code-object/method.test.ts b/test/code-object/method.test.ts
@@ -14,4 +14,16 @@ describe("method", () => {
         expect(ToString(method.ToClassMethod())).toMatchSnapshot();
         expect(method.m_ClassName).toEqual("Foo");
     });
+
+    test("default value", () => {
+        const method = new MethodCode(
+            ToNodePath<ExpressionStatement>(`
+            <Foo/> + function Test(this: Foo, a: number, b: string = ""){
+                return a.toString()+b;
+            }
+        `)
+        );
+
+        expect(ToString(method.ToClassMethod())).toMatchSnapshot();
+    });
 });