Remove setting of the _root_ logger level as this is best done by the… #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it: The root logger should not be changed by a library. The reason for this is that now anyone using Mistral Client will have their root logger changed and log statements in the calling code will be affected (both by the level and the formatting). This behavior can be seen by the following snippet:
The logger warning will only be displayed if the second line is commented, because otherwise the log level will be set to ERROR.
The suggested solution is to leave the formatting and level to the end user (calling code) and remove it from here.