Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging and wrapper around 'log' #31

Merged
merged 5 commits into from Nov 1, 2015
Merged

Better logging and wrapper around 'log' #31

merged 5 commits into from Nov 1, 2015

Conversation

DenBeke
Copy link
Contributor

@DenBeke DenBeke commented Oct 30, 2015

Created a wrapper around log, and used it to change to Logrus.

This pull request is no more than changing the logger. So no extra log info, levels, details, ... were added. I will update this PR if I worked more on it. (You can also push to this branch...)

schermafbeelding 2015-10-30 om 22 04 36

@DenBeke
Copy link
Contributor Author

DenBeke commented Oct 31, 2015

I've added some nice levels...

schermafbeelding 2015-10-31 om 16 45 35

I also added a SessionId and the Ip to the state.

@DenBeke DenBeke changed the title Wrapper around 'log' Better logging and wrapper around 'log' Oct 31, 2015
(Pushed into this branch so I don't need to rewrite logging again for those new statements)
@trtstm
Copy link
Contributor

trtstm commented Nov 1, 2015

sure

used for Authentication-Results header, fixes #32
@DenBeke
Copy link
Contributor Author

DenBeke commented Nov 1, 2015

Ready to merge... Except if you want to do those changes before merging...

I think adding a method GetIp() to the smtp.Protocol is the cleanest way.

@trtstm
Copy link
Contributor

trtstm commented Nov 1, 2015

That can wait :)

@trtstm trtstm closed this Nov 1, 2015
@trtstm trtstm reopened this Nov 1, 2015
trtstm added a commit that referenced this pull request Nov 1, 2015
Better logging and wrapper around 'log'
@trtstm trtstm merged commit 965634f into master Nov 1, 2015
@DenBeke
Copy link
Contributor Author

DenBeke commented Nov 1, 2015

That can wait :)

Make an issue for it :p

@trtstm trtstm mentioned this pull request Nov 1, 2015
@DenBeke DenBeke deleted the logging branch October 16, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants