Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support FreeBSD #58

Closed
wants to merge 2 commits into from
Closed

support FreeBSD #58

wants to merge 2 commits into from

Conversation

dch
Copy link

@dch dch commented Apr 2, 2024

I did this in line with the existing code for simplicity

  • scripts are bash style, not posix shell, so make this explicit
  • trim up trailing whitespace
  • add FreeBSD architecture support

I think there may be simpler / cleaner ways to accommodate this
overall approach but this seems a good start.

Testing was done with:

Build type: Release
LuaJIT 2.1.1699801871

snap

@dch
Copy link
Author

dch commented Apr 2, 2024

If you plan to cross-build the rust libraries in CI or similar,
here's output of uname etc, the code might need to be amended
in that case.

# uname
FreeBSD

### now on x86_64
# uname -m
amd64

### now on aarch64
# uname -m
arm64

@dch
Copy link
Author

dch commented Apr 2, 2024

NB the weird glyph is actually a light grey background >... visible whitespace. Not
quite sure how to hide/fix that?

@mistricky
Copy link
Owner

Hi @dch, thx for this PR, if you wanna support FreeBSD, you also need to update the github actions config. But I don't wanna add too many cross-compilation target. I only have 2000 minutes per month usage time for GitHub actions, and the mac CI expensive more :(

Cross-compile is just an option which allow most users to use CodeSnap.nvim out of box, if your OS not in the cross-compilation list, you can still compile CodeSnap.nvim from source use make build_generator command.

@mistricky
Copy link
Owner

mistricky commented Apr 2, 2024

NB the weird glyph is actually a light grey background >... visible whitespace. Not
quite sure how to hide/fix that?

Did you found the reproduce path? I can't reproduce this bug on my machine

@mistricky
Copy link
Owner

Hey @dch if you found reproduce path, you can open another issue to report it, this PR closed now.

@mistricky mistricky closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants