Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cmd non-blocking #42

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

coltorl
Copy link
Contributor

@coltorl coltorl commented Jul 10, 2024

Addresses #41

@coltorl coltorl requested a review from gorillamoe as a code owner July 10, 2024 01:35
@gorillamoe gorillamoe self-assigned this Jul 10, 2024
@gorillamoe gorillamoe added the enhancement New feature or request label Jul 10, 2024
@yujinyuz
Copy link
Contributor

I also tested this and seems like a good solution.

But the only problem so far is that if the API responds too long, it immediately shows the results of an old request

@gorillamoe
Copy link
Member

gorillamoe commented Jul 10, 2024

@coltorl @yujinyuz , thanks for helping to make kulala really nice. I fixed the issue that @yujinyuz reported. I think we're good to go. Let's push it to production :)

@gorillamoe gorillamoe merged commit 6b1f35f into mistweaverco:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants