Emit disable event code only if no active handler exists #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change that produced calls to EventDispatcher's unregister method for disabled blocks did not account for the scenario where both an active and inactive event handler exist for the same component-event combination. This change makes it so that unregister calls are only output if there isn't a matching active event handler. Change-Id: If33b577f5af03c64f7abb8fe5b587d576886889b
jisqyv
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change that produced calls to EventDispatcher's unregister method
for disabled blocks did not account for the scenario where both an
active and inactive event handler exist for the same component-event
combination. This change makes it so that unregister calls are only
output if there isn't a matching active event handler.
Fixes #1918
Change-Id: If33b577f5af03c64f7abb8fe5b587d576886889b