New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [GSoC] Add Tab Arrangement and Tab components. #2224
base: ucr
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Let us fix the coding style first.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(tabBarVisible) {
Leave a space between if and ( to be consistent with the coding style in appinventor.
Issue I observe: |
Please rebase the branch on ucr since the changes for android sdk29 have been merged so that this branch only contains the changes for tab and tab arrangement. |
import com.google.appinventor.client.editor.youngandroid.properties.YoungAndroidThemeChoicePropertyEditor; | ||
import com.google.appinventor.client.editor.youngandroid.properties.YoungAndroidToastLengthChoicePropertyEditor; | ||
import com.google.appinventor.client.editor.youngandroid.properties.YoungAndroidVerticalAlignmentChoicePropertyEditor; | ||
import com.google.appinventor.client.editor.youngandroid.properties.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want use to ambitious wildcard imports.
import com.google.appinventor.client.editor.simple.components.MockVerticalArrangement; | ||
import com.google.appinventor.client.editor.simple.components.MockVideoPlayer; | ||
import com.google.appinventor.client.editor.simple.components.MockWebViewer; | ||
import com.google.appinventor.client.editor.simple.components.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same case here. no * import.
This branch is no longer compilable. Could you take a look please? |
@ellelili2025 I've rebased my branch and fixed the build errors. Please let me know if it is still not compilable. |
This is a draft PR, submitted for the evaluations.
I've added 2 components: TabArrangement and Tab
The properties implemented for both the components are listed below:
1.) TabArrangement
2.) Tab
@ellelili2025 Kindly have a look.