Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Adding Different Preview Options To The Designer #2227

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

HimaniKaul
Copy link
Contributor

@HimaniKaul HimaniKaul commented Jul 1, 2020

This summer I have worked on improving the MockForm by adding three different preview options in the Designer. The preview options are Android Material (Android 5+), Android Holo (Android 3.0-4.4.2) and introducing the new iPhone/iPad (iOS 13) MockForm so that users can preview their apps and get to know how it will look on different platforms.

@AppInventorWorkerBee
Copy link
Collaborator

Can one of the admins verify this patch?

@HimaniKaul HimaniKaul changed the title H branch [GSoC] [Work In Progress] Adding Different Preview Options To The Designer Jul 1, 2020
@ewpatton ewpatton requested a review from a team July 1, 2020 21:18
@HimaniKaul HimaniKaul closed this Aug 30, 2020
@HimaniKaul HimaniKaul reopened this Aug 30, 2020
@ewpatton ewpatton added this to the GSOC Release milestone Sep 1, 2020
@HimaniKaul HimaniKaul marked this pull request as ready for review September 4, 2020 16:45
@HimaniKaul HimaniKaul changed the title [GSoC] [Work In Progress] Adding Different Preview Options To The Designer [GSoC] Adding Different Preview Options To The Designer Sep 4, 2020
@ewpatton ewpatton mentioned this pull request Dec 1, 2020
@ewpatton ewpatton modified the milestones: GSOC Release, nb187 Dec 1, 2020
@ewpatton ewpatton added the on ai2-test Code is deployed on ai2-test.appinventor.mit.edu label Dec 21, 2020
@ewpatton
Copy link
Member

@HimaniKaul this has conflicts now with #2331. I've done my best to resolve them for deploying this on our test server but it doesn't look quite right, especially for the iPhone version. Would you mind reconciling this with master when you have a chance?

@jisqyv
Copy link
Member

jisqyv commented Dec 22, 2020

@HimaniKaul @ewpatton Looks like an extraneous copy of the adb binary is included in this PR. Please flush (Himani: We can take care of this). This note is mostly so we don't forget!

@HimaniKaul
Copy link
Contributor Author

@jisqyv @ewpatton Sure, I will still have a look on it.

@jisqyv
Copy link
Member

jisqyv commented Mar 11, 2021

@HimaniKaul I'm about to push to your branch. I have done some work bringing your work up-to-date to the current master.

@jisqyv jisqyv force-pushed the HBranch branch 2 times, most recently from 3c9d586 to cdc6c1c Compare March 11, 2021 22:57
@jisqyv jisqyv mentioned this pull request Mar 11, 2021
@HimaniKaul
Copy link
Contributor Author

@jisqyv Okay!

@jisqyv
Copy link
Member

jisqyv commented Mar 12, 2021

@HimaniKaul I backed out the changes you made to MockSwitch. This was a policy decision. Although your change made the Classic theme correct for API 7, after API 14 the switch appears like a switch (not a checkbox) on devices in Classic mode. Given that almost all of our users are now using devices at or beyond API 14, we figured this makes more sense.

I believe we are very close to merging this change

@HimaniKaul
Copy link
Contributor Author

@jisqyv Okay.

Change-Id: I3f186175afcb254bc9a329c2a0f445fc0e42b48a
Copy link
Member

@jisqyv jisqyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jisqyv jisqyv merged commit 9b649e8 into mit-cml:master Mar 17, 2021
@jisqyv
Copy link
Member

jisqyv commented Mar 17, 2021

@HimaniKaul Merged!

@pratyaksh177
Copy link

hellow @HimaniKaul I am fresers and actually I have little knowledge about open source. I know java language . If you dont mind will you please guide me :) pratyakshraj17@gmail.com

@jisqyv jisqyv removed the on ai2-test Code is deployed on ai2-test.appinventor.mit.edu label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants