-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Adding Different Preview Options To The Designer #2227
Conversation
Can one of the admins verify this patch? |
@HimaniKaul this has conflicts now with #2331. I've done my best to resolve them for deploying this on our test server but it doesn't look quite right, especially for the iPhone version. Would you mind reconciling this with master when you have a chance? |
@HimaniKaul @ewpatton Looks like an extraneous copy of the adb binary is included in this PR. Please flush (Himani: We can take care of this). This note is mostly so we don't forget! |
@HimaniKaul I'm about to push to your branch. I have done some work bringing your work up-to-date to the current master. |
3c9d586
to
cdc6c1c
Compare
@jisqyv Okay! |
@HimaniKaul I backed out the changes you made to MockSwitch. This was a policy decision. Although your change made the Classic theme correct for API 7, after API 14 the switch appears like a switch (not a checkbox) on devices in Classic mode. Given that almost all of our users are now using devices at or beyond API 14, we figured this makes more sense. I believe we are very close to merging this change |
@jisqyv Okay. |
Change-Id: I3f186175afcb254bc9a329c2a0f445fc0e42b48a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HimaniKaul Merged! |
hellow @HimaniKaul I am fresers and actually I have little knowledge about open source. I know java language . If you dont mind will you please guide me :) pratyakshraj17@gmail.com |
This summer I have worked on improving the MockForm by adding three different preview options in the Designer. The preview options are Android Material (Android 5+), Android Holo (Android 3.0-4.4.2) and introducing the new iPhone/iPad (iOS 13) MockForm so that users can preview their apps and get to know how it will look on different platforms.