Fix WebViewer crash on old Android due to NPE #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to reference assets using http://localhost/ as an authority fail on older versions of Android due to a NullPointerException caused by the MIME type lookup returning null rather than a valid MIME type. This can happen even for common file types like JavaScript files. Newer versions of Android have a more complete MIME type table and don't exhibit this issue. Change-Id: I3f1b3846262f0c1613ad7807c1758a7d24fb246d
|
Relevant forum thread: https://community.appinventor.mit.edu/t/webviewer-automatic-crash-2/15667/11?u=ewpatton |
|
I tested on SDK 21 (5.0 Lollipop), SDK 14 (4.0 Ice Cream Sandwich) and SDK 11 (Honeycomb). All but the last worked, and the latter loaded but crashed when attempting to show the alert dialog deep within the Android code. My guess is that this has something to do with themes and nothing to do with the WebViewer logic (our code isn't anywhere in the stack trace). Given that most Honeycomb devices likely would have had an upgrade path to ICS, I'm willing to overlook that. |
jisqyv
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to reference assets using http://localhost/ as an
authority fail on older versions of Android due to a
NullPointerException caused by the MIME type lookup returning null
rather than a valid MIME type. This can happen even for common file
types like JavaScript files. Newer versions of Android have a more
complete MIME type table and don't exhibit this issue.
Change-Id: I3f1b3846262f0c1613ad7807c1758a7d24fb246d