Make use of targetWorkspace where applicable #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I24592add7f7416befc3ecc4a37b860c985f818e9
BeksOmega
approved these changes
Jan 8, 2022
|
@BeksOmega The underlying issue I saw was that mainWorkspace was becoming the fly out, which I believe is fixed by my monkey patch to markFocused. We should probably move to using options.parentWorkspace from targetWorkspace in the future. I may clean this up a bit further because I do think somewhere we have a getTopWorkspace method that always returns the real workspace. |
ellelili2025
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2625
Change-Id: I24592add7f7416befc3ecc4a37b860c985f818e9