Fix buttons not taking a translucent background color

[ewpatton]

Change-Id: I7781e710b4c3efd41c9585e2e5cd4c6cc2d50736

[ewpatton]

Note that I have not yet tested this on a version of Android lower than SDK 21 Lollipop.

[ewpatton]

Here is an example of what this looks like. Button2 has a blue background with 50% transparency which yields a purple tint, Button3 has a yellow background with 50% transparency which yields an orange tint, and Button4 has no background, which also needs the shadow suppressed (the state/outline manipulation is responsible for this).

[jisqyv]

FATAL EXCEPTION: main │
│E/AndroidRuntime( 3067): java.lang.NoClassDefFoundError: android/view/ViewOutlineProvider

on KitKat

[ewpatton]

@jisqyv I've pushed two changes. The first fixes the crash on Android versions prior to 5.0. The second one removes a check that no longer seems to be need which forces the background color in Device Default and other themes to be white. The latter was something I bumped into when testing using the old emulator running Android 2.x using the button test project previously shared. We may want to keep the last commit separate since it's somewhat independent of the original reason for this change (but needed if testing the change on an old version of Android).

[ewpatton]

[jisqyv]

@ewpatton I've tested this on KitKat (emulated) and on my phone. The Companion no longer crashes on KitKat. However the test app doesn't look the same (different colors) and on KitKat the "Screen 1" text does not show up. Here is a link to a zip file with screenshots from both the KitKat (emulated) and my phone.

https://r2.qyv.net/share/QeNyMz4L
(note: Link may have a limited lifetime, if you are viewing this comment in the future, it may not work)

[jisqyv]

LGTM