Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Assets conform to SLIP-0044 #15

Open
Rjected opened this issue May 23, 2019 · 2 comments
Open

Make Assets conform to SLIP-0044 #15

Rjected opened this issue May 23, 2019 · 2 comments
Labels
feature New feature or request good first issue Good for newcomers refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization

Comments

@Rjected
Copy link
Collaborator

Rjected commented May 23, 2019

Is your feature request related to a problem? Please describe.
Currently the Asset struct assigns arbitrary, non-standard bytes to be used for asset identification by the server. It would be useful to include a standard that can be used for both BIP-0044 (as the HDCoinType) and the exchange (as an asset identifier). SLIP-0044 solves this problem, so it would make sense to implement this as the definition of the Asset struct.

Describe the solution you'd like
Implement SLIP-0044 as the definition of the Asset struct and make sure all of the cointypes that come from lit repo use it, or are compatible with the rest of opencx.

Describe alternatives you've considered
There do not seem to be many alternatives other than using the coin types in lit coinparams.

Additional context
N/A

@Rjected Rjected added feature New feature or request good first issue Good for newcomers labels May 23, 2019
@Rjected Rjected added this to Next up in OpenCX Development May 23, 2019
@Rjected Rjected added the refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization label May 28, 2019
@metalicjames
Copy link
Member

metalicjames commented Jun 4, 2019

FYI the cointypes in the Lit params are supposed to be slip-0044 conforming.

@Rjected
Copy link
Collaborator Author

Rjected commented Jun 5, 2019

Good to know, that should make a lot of things pretty easy then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization
Projects
Development

No branches or pull requests

2 participants