Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better way to represent a trading pair #23

Open
Rjected opened this issue Jun 3, 2019 · 0 comments
Open

Need a better way to represent a trading pair #23

Rjected opened this issue Jun 3, 2019 · 0 comments
Labels
feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization

Comments

@Rjected
Copy link
Collaborator

Rjected commented Jun 3, 2019

Is your feature request related to a problem? Please describe.
Currently, we can represent the same trading pair two different ways (BTC/LTC or LTC/BTC). In cxdbsql we just keep one table which has one of the assets first, and the other second. So there will only be regtest_litereg and not litereg_regtest. Instead, there should be one way of representing an asset pair. #15 should be done before this.

Describe the solution you'd like
#15 will give a nice ordering of assets, so maybe the lower asset ID can always go first. Trading pairs can have two non-equal Asset ID's, pairs will be unique if they are ordered.

Describe alternatives you've considered
The greater asset ID could go first, but it really doesn't matter.

Additional context
N/A

@Rjected Rjected added feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization labels Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization
Projects
None yet
Development

No branches or pull requests

1 participant