Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this a bug? #27

Closed
anguoyang opened this issue Oct 19, 2022 · 4 comments
Closed

is this a bug? #27

anguoyang opened this issue Oct 19, 2022 · 4 comments

Comments

@anguoyang
Copy link

Hi @junyanz @songhan , I found a possible bug, not sure, if not please correct me, thank you.
when you calculate the fid, you use the transform with random flip:
https://github.com/mit-han-lab/anycost-gan/blob/master/tools/calc_inception.py#L53
but when training code, there is just clamp, no flip:
https://github.com/mit-han-lab/anycost-gan/blob/master/tools/train_gan.py#L279
That maybe lead to wrong evaluation result

@tonylins
Copy link
Contributor

Hi, thanks for the comment. We do not enable the --flip argument when computing inception features, so no flipping is used in both cases. Please refer to the command in the README when using calc_inception.py.

@anguoyang
Copy link
Author

Hi, thanks for your feedback, another issue, it seems that you used the same data loader for evaluation(or part of the train loader), do you think it is better to split for train/val?

@tonylins
Copy link
Contributor

We used the same practice to calculate FIDs as StyleGAN2, where the training set is used for FID calculation.

@anguoyang
Copy link
Author

thanks, got it. by the way, I tried resnet50 encoder to replace the mapping network in my face image enhancement task(keep the synthesis network), I found the result is much worse(compare with GPEN which modified from styleGAN2), the result image is similar with ESRGAN's, how to say, it is clear enough but obvious fake for human eyes, not sure how to slim the default StyleGAN2 mapping network...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants