Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strict validation against Hydra's supported primitives #163

Merged
merged 38 commits into from Nov 26, 2021
Merged

Add strict validation against Hydra's supported primitives #163

merged 38 commits into from Nov 26, 2021

Commits on Nov 13, 2021

  1. add initial framework for zen value conversion

    @rsokl
    rsokl committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    9c99844 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Validate that all configured values satisfy Hydra serializability

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    117a495 View commit details
    Browse the repository at this point in the history

  2. bugfix: ref to wrong variable

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    a77e6b5 View commit details
    Browse the repository at this point in the history

  3. cleanup test boilerplate

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    80ce1e8 View commit details
    Browse the repository at this point in the history

  4. fix bug

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    69fcc32 View commit details
    Browse the repository at this point in the history

  5. add support for set; normalize builds-error

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7b5e777 View commit details
    Browse the repository at this point in the history

  6. add validation/conversion to contents of supported collections: tuple… 

    …,list,dict
    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    da8577a View commit details
    Browse the repository at this point in the history

  7. Validation now requires exact match against types -- subclasses no lo… 

    …nger permitted
    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    ce775ea View commit details
    Browse the repository at this point in the history

  8. add tests for zen-supported primitives

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3a1936b View commit details
    Browse the repository at this point in the history

  9. add support for complex values

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3c51fb7 View commit details
    Browse the repository at this point in the history

  10. add support for Path objects

    @rsokl
    rsokl committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    9063dac View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. remove extra complex implementation

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    4d76cce View commit details
    Browse the repository at this point in the history

  2. update type-annotations to reflect supported primitives

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d260196 View commit details
    Browse the repository at this point in the history

  3. add frozenset support

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0d1ab7d View commit details
    Browse the repository at this point in the history

  4. improve test

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cae567f View commit details
    Browse the repository at this point in the history

  5. relax health checks

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8c147ce View commit details
    Browse the repository at this point in the history

  6. eliminate redundant dict copy

    @rsokl
    rsokl committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    35f4881 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. ensure zen-converted values are supported by Hydra

    @rsokl
    rsokl committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    46a3216 View commit details
    Browse the repository at this point in the history

  2. Add support for enum members

    @rsokl
    rsokl committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2459b4c View commit details
    Browse the repository at this point in the history

  3. add explicit tests for supported primitives

    @rsokl
    rsokl committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    245f0cd View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. add support for additional primitives

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    986dd5c View commit details
    Browse the repository at this point in the history

  2. remove straggler line

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d8a7fe3 View commit details
    Browse the repository at this point in the history

  3. clean up import

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    21a14fa View commit details
    Browse the repository at this point in the history

  4. make test compatible with python 3.6

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    358c9b2 View commit details
    Browse the repository at this point in the history

  5. remove unused imports

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    62496a8 View commit details
    Browse the repository at this point in the history

  6. dataclasses are not permitted for dict-key nodes

    @rsokl
    rsokl committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c9d5aea View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. inline just-if-needed; dont permit structured configs as keys

    @rsokl
    rsokl committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6303a77 View commit details
    Browse the repository at this point in the history

  2. add support for omegaconf containers

    @rsokl
    rsokl committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    208fa4e View commit details
    Browse the repository at this point in the history

  3. ensure omegaconf containers not permitted as dict keys

    @rsokl
    rsokl committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    935da18 View commit details
    Browse the repository at this point in the history

  4. remove unused function

    @rsokl
    rsokl committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d5d73aa View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. add annotation support for range; remove redundant annotations

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c383825 View commit details
    Browse the repository at this point in the history

  2. remove future import

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8a8ad2d View commit details
    Browse the repository at this point in the history

  3. remove unused import

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    52a95eb View commit details
    Browse the repository at this point in the history

  4. add docs for features

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    423e5fd View commit details
    Browse the repository at this point in the history

  5. wrap long line

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b3622dc View commit details
    Browse the repository at this point in the history

  6. test that meta fields are validated too

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    7481afb View commit details
    Browse the repository at this point in the history

  7. remove commented print

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    bc83d42 View commit details
    Browse the repository at this point in the history

  8. fix bad test

    @rsokl
    rsokl committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2a20bb8 View commit details
    Browse the repository at this point in the history