Adds hydra_defaults
to builds
and make_config
#264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253
There is now formal support for specifying a Defaults List via
builds
andmake_config
:Previously, one needed to specify
defaults
as a meta-field inbuilds
, which was more complex for the user and which made the resulting yaml more verbose.For
make_config
, one can specifydefaults
instead ofhydra_defaults
-- for the sake of parity with how a structured config is written -- to the same effect. Specifyingdefaults
andhydra_defaults
simultaneously raises an error.Validation performed on
hydra_defaults
Basic runtime type-checking is performed on
hydra_defaults
:Static type checkers will also flag bad defaults lists:
We also make some attempt to do some basic value validation as well. Specifically, we raise on duplicate
"_self_"
entries:And we warn users when
"_self_"
is not present:Presently,
hydra_defaults
is overly permissive; it would be nice to provide stricter value-validation on its contents.