Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds version_base to launch #273

Merged
merged 5 commits into from May 7, 2022
Merged

Adds version_base to launch #273

merged 5 commits into from May 7, 2022

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented May 6, 2022

This mirrors functionality that will be exposed by hydra.run and hydra.initialize starting with Hydra 1.2.0:

  • If the version_base parameter is not specified, Hydra 1.x will use defaults compatible with version 1.1. Also in this case, a warning is issued to indicate an explicit version_base is preferred.
  • If the version_base parameter is None, then the defaults are chosen for the current minor Hydra version. For example for Hydra 1.2, then would imply config_path=None and hydra.job.chdir=False.
  • If the version_base parameter is an explicit version string like "1.1", then the defaults appropriate to that version are used.

Our tests will specify version_base in accordance with the local version of Hydra, unless otherwise appropriate, via a pytest fixture.

@rsokl rsokl added enhancement New feature or request hydra/omegaconf Tied to behavior of hydra/omegaconf labels May 6, 2022
@rsokl rsokl added this to the hydra-zen 0.7.0 milestone May 6, 2022
@rsokl rsokl requested a review from jgbos May 6, 2022 20:29
@rsokl rsokl merged commit 34a1acf into main May 7, 2022
@rsokl rsokl deleted the version-base branch May 7, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hydra/omegaconf Tied to behavior of hydra/omegaconf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants