New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customizable auto-config support to builds
et al
#553
Merged
+3,015
−2,377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en into modularity
rsokl
added a commit
that referenced
this pull request
Oct 25, 2023
Add customizable auto-config support to `builds` et al
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a type
BuildsFn
, which exposes all of the type-refinement and auto-config capabilities that are leverages bybuilds
,just
, andmake_config
. The idea here is that users can now add customized auto-config and type-refinement support for their own types to their own versions ofbuilds
,just,
etc.This has been a feature that we have considered adding to hydra-zen for a while, but the issue was that we did not know how to provide type-checking support when users could ostensibly make new types acceptable to, e.g.,
builds
. The way that this is solved is thatBuildsFn
is a generic, whose type-var describes the types that are accepted by that specific implementation ofBuildsFn
.E.g.
builds = BuildsFn[SupportedPrimitives].builds
reflects the typicalbuilds
function. But suppose you want to add custom auto-config support for instances ofMyType
. You can do:Now you can do
and
my_builds
will know how to automatically (and recursively!) convertMyType
into a hydra-compatible config!Defining a Protocol for Automatic Configurablility
Here is an example where we define a protocol that enables a type to describe how to access the kwargs that describe one of its instances. We will create a version of
BuildsFn
that will check if an object implements this protocol; if it does, thebuilds
/just
/make_config
functions will know how to "automatically" create a config describing the object.This is an extremely powerful pattern. It means that 3rd party types can make themselves automatically-configurable in your experiment framework by implementing simply this simple protocol, which you designed. 3rd parties need not modify your implementation of
BuildsFn
.Seeing the config-creation functions in action.