Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: optionally pass params for hyperparam line search in trainer.train() methods #80

Open
amn41 opened this issue Nov 8, 2016 · 1 comment

Comments

@amn41
Copy link
Contributor

amn41 commented Nov 8, 2016

for the ner_trainer and text_categorizer_trainer classes, the train method offers no control over the window (eps) or max_iter of the find_max_single_variable function.

I would propose to make those optional args to the train methods.

@davisking
Copy link
Contributor

Sure, that's fine with me so long as it's clear that users are expected to not need to modify those parameters. So such a PR would be welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants