Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to controller was broken with directory changes #169

Merged
merged 7 commits into from Dec 7, 2020

Conversation

ptravers
Copy link
Contributor

@ptravers ptravers commented Sep 3, 2020

Not totally sure if this is the same as the original linked code. But it seemed the most similar of the code I could see.

@ms705
Copy link
Member

ms705 commented Sep 3, 2020

Thanks for this! The fix for data.rs looks good, but the equivalent path to inner.rs is now server/src/controller/inner.rs.

@ptravers
Copy link
Contributor Author

ptravers commented Sep 3, 2020

@ms705 ah cool! will fix that now!

@ptravers
Copy link
Contributor Author

ptravers commented Sep 3, 2020

Should I rewrite that part of the README given the code is no longer in the noria crate? I would propose moving that line including the controller/inner.rs to the server section of the README.

@ms705
Copy link
Member

ms705 commented Dec 7, 2020

Thanks! The README is fine as-is, since it refers to the client invoking controller RPCs.

@ms705 ms705 merged commit 6611af5 into mit-pdos:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants