New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arithmetic Expressions in Projections #30
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c1bd87d
Initial arithmetic support in Project
ekmartin a2f7140
Use a macro for arithmetic DataType operations
ekmartin a9eeb92
Add tests for literal arithmetic
ekmartin af2832f
Handle ArithmeticExpressions from nom-sql
ekmartin ddb7043
Add a FLOAT_PRECISION constant
ekmartin 8978a11
Handle arithmetic and literal names together
ekmartin 72f6dfc
Add computed columns if they're used in arithmetic expressions
ekmartin 059ffaf
Implement formatting for arithmetic expressions
ekmartin 811ca80
Only re-use arithmetic expressions without functions
ekmartin 688e85f
Use MAX in arithmetic test
ekmartin a0df5f5
Merge branch 'master' into arithmetic
ekmartin a492cb0
Use g.migrate instead of start_migration
ekmartin 292566e
&*mig -> mig
ekmartin 475cb89
Merge branch 'master' into arithmetic
ekmartin 70340d3
rustfmt
ekmartin 956c328
Merge branch 'master' into arithmetic
ekmartin 436333c
thread::sleep(...) -> sleep()
ekmartin 85044bf
len() > 0 -> is_empty()
ekmartin 28a9dad
Add a test for multiple arithmetic expressions
ekmartin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite conservative (though probably fine for v0 of arithmetic expression support): it will only allow reuse of projections that have exactly identical arithmetic expressions. For example, with multiple elements in the
arithmetic
vector, it would only reuse the projection if the vectors have the same elements and they're all identical. However, it is also acceptable to reuse the projection if the newour_arithmetic
is a strict subset ofarithmetic
.Now, you might observe that we are similarly unnecessarily strict about
emit
, and you'd be right ;-)