-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GarageDoor does not fit within Coq CI memory limit #1427
Comments
I blindly created #1428, does our CI show enough info to see how much that helps? |
Yes, the CI should show a table of time and memory usage at the bottom of each step |
4252172 ko after #1429 |
This is better (thanks!), but I think we need to be under 3.5GB for Coq's CI |
I created #1431 but I don't think it'll do it either. But wait, Coq CI got almost to the end of the file previously, to the large lemma that is now replaced with something hopefully very small? |
I bumped coq-scripts to have the newly written script Timing and memory diffs on each line (be wary that some are out of order)
The heaviest individual lines, memoy-wise, are
Timewise, the slowest lines are
|
2332608 ko after #1431 |
https://gitlab.com/coq/coq/-/jobs/3168928488 is a CI job off of coq/coq#16648 . I restarted the pipeline before merging #1431 but as the particular job hasn't started I'd guess it'll pick up fiat-crypto master anyway. If it passes, I think we're "good" on this issue. |
It passes at https://github.com/coq/coq/pull/16648/checks?check_run_id=8884687370 Thanks all! |
GarageDoor uses too much RAM for Coq's CI. Either we should provide a target that excludes only GarageDoor and it's reverse dependencies, or we should perfomance-optimize GarageDoor.
https://github.com/coq/coq/runs/8838127340
coq/coq#16638 (comment)
cc @andres-erbsen
The text was updated successfully, but these errors were encountered: