use vm_compute instead of Ltac to check instruction bounds #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
reviewed
Oct 13, 2022
| Definition good_trace s t s' := | ||
| exists ioh, SPI.mmio_trace_abstraction_relation ioh t /\ | ||
| bverify.bvalidInstructions Decode.RV32IM garagedoor_insns = true. | ||
| Proof. vm_compute. reflexivity. Qed. |
There was a problem hiding this comment.
Why not
Suggested change
| Proof. vm_compute. reflexivity. Qed. | |
| Proof. vm_cast_no_check (eq_refl true). Qed. |
? (Is it slow enough to matter?)
There was a problem hiding this comment.
? (Is it slow enough to matter?)
It's instantaneous, so the question I asked myself was whether to keep it as a separate lemma at all, not how to optimize it 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve #1427
Closes #1428