Mem extension (part 1) #1166
Merged
Mem extension (part 1) #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[reg] (for mov reg, [rsp]) [reg +/- z ] (for mov reg, [rsp +- 0x8], spills to memory) [reg + reg] (for lea reg, [reg + reg], to calculate *2) [z * reg] (for lea reg, [2/4/8 * reg], to calculate *2, *4, *8) [reg + z * reg] (for lea reg, [reg + 2*reg] to calculat
Co-authored-by: Jason Gross <jasongross9@gmail.com>
Co-authored-by: Jason Gross <jasongross9@gmail.com>
`parse_Z_arith_strict` permits whitespace both before and after, so we were overlapping whitespace patterns.
Co-authored-by: Jason Gross <jasongross9@gmail.com>
Roughly the issue is that app_consts leaves over spurious x * 1 that don't get removed by subsequent passes. c.f. mit-plv#1134 (comment)
JasonGross
added
awaiting-continuous-integration-check
and removed
awaiting-continuous-integration-check
labels
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of #1134 that (hopefully) passes CI. I will merge it once the CI passes, and we can continue development on #1134.