Add reveal_at_least, a more clever form of reveal #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depth determines which indices get expanded, but all references to the same index get expanded if they appear in the output. This is because Joel's latest examples require a rewriting pass that needs either uneven revealing or the ability to check expression equality modulo the dag in the middle of rewriting. mit-plv#1134 (comment) Roughly the issue is that if we want to turn `a + 4 * a` into `5 * a`, we need to reveal enough structure to see `4 * a`, but we need to see that the two instances of `a` are the same (e.g., if `a` is an ExprRef pointing to `b|c`, and we reveal uniformly, then we need to recognize `b|c + 4 * a`)
Merged
|
Windows CI failed with the periodic “Terminate Batch Job (Y/N)?”, see e.g., https://github.community/t/windows-github-action-randomly-freezes/16690/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth determines which indices get expanded, but all references to the
same index get expanded if they appear in the output.
This is because Joel's latest examples require a rewriting pass that
needs either uneven revealing or the ability to check expression
equality modulo the dag in the middle of rewriting.
#1134 (comment)
Roughly the issue is that if we want to turn
a + 4 * ainto5 * a,we need to reveal enough structure to see
4 * a, but we need to seethat the two instances of
aare the same (e.g., ifais an ExprRefpointing to
b|c, and we reveal uniformly, then we need to recognizeb|c + 4 * a)