Compatibility with respect to Coq PR#262 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coq PR#262 makes the inference of return clauses more uniform and general but unification is sometimes not strong enough to deal with this generality. See #5107 for details. One reduces the search space for a return clause by forbidding it to be obtained by small inversion.
|
@herbelin I just ran into this again (coq/coq#9955) can you explain (here or maybe better, there), why we need to restrict the search space? It seems like Coq should always be able to find the solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear fiat-crypto developers, this is a patch for compatibility with PR coq/coq#262.
PR coq/coq#262 makes the inference of return clauses more uniform and general but unification is sometimes not strong enough to deal with this generality. See coq/coq#5107 for details.
One reduces the search space for the return clause by forbidding it to be obtained by small inversion (using a
return _).Note that the patch is backwards compatible and can be applied as soon as now, even with PR coq/coq#262 not yet merged.