Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to coq/coq#17836 (sort poly) #109

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Adapt to coq/coq#17836 (sort poly) #109

merged 1 commit into from
Nov 6, 2023

Conversation

SkySkimmer
Copy link
Contributor

No description provided.

JasonGross
JasonGross requested changes Sep 18, 2023
View reviewed changes
src/Rewriter/Util/Tactics2/DestProj.v Outdated Show resolved Hide resolved
src/Rewriter/Rewriter/Reify.v Outdated Show resolved Hide resolved
src/Rewriter/Language/Reify.v Outdated Show resolved Hide resolved
src/Rewriter/Util/Tactics2/Constr.v Outdated Show resolved Hide resolved
src/Rewriter/Util/Tactics2/Proj.v Outdated Show resolved Hide resolved
@SkySkimmer
Copy link
Contributor Author

That's a lot of work for the overlay writer dealing with a build system I'm not familiar with. Can you do it yourself?

@JasonGross
Copy link
Collaborator

Sure, what's the timeline on getting the PR merged? It'll probably take me a couple days at least to find time.

@SkySkimmer
Copy link
Contributor Author

Probably not this week, I haven't finished the overlays and the doc, and then we will need reviewing and perf discussion etc

@SkySkimmer SkySkimmer mentioned this pull request Sep 19, 2023
Merged
6 tasks
@JasonGross JasonGross mentioned this pull request Sep 19, 2023
Merged
@JasonGross
Copy link
Collaborator

I hope #113 will pass CI and auto-merge in about 10--20 minutes. #114 will take care of Proj.v, which is already compatible. If you rebase this PR on top of that one, the changes should be pretty minimal (just the two v819 Tactics2 files). Though if the constr iter functions can be upstreamed in Coq, that'd be even better

JasonGross
JasonGross reviewed Sep 22, 2023
View reviewed changes
src/Rewriter/Util/Tactics2/Constr.v.v818 Outdated Show resolved Hide resolved
src/Rewriter/Util/Tactics2/DestProj.v.v818 Outdated Show resolved Hide resolved
src/Rewriter/Util/Tactics2/Proj.v.v816 Outdated Show resolved Hide resolved
JasonGross
JasonGross approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@JasonGross JasonGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge once the Coq PR lands and CI here passes

@SkySkimmer SkySkimmer marked this pull request as ready for review November 6, 2023 20:46
@ppedrot
Copy link
Contributor

ppedrot commented Nov 6, 2023

Please merge now.

@JasonGross JasonGross enabled auto-merge (squash) November 6, 2023 23:24
@JasonGross JasonGross merged commit 5e74224 into mit-plv:master Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGross JasonGross JasonGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SkySkimmer @JasonGross @ppedrot