Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish and French translations #142

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

madd0
Copy link
Contributor

@madd0 madd0 commented Feb 11, 2023

I noticed translations were recently introduced and wanted to contribute Spanish and French.

I also cleaned up the spacing in existing translations. (Hope it's not a problem, but it's a commit of its own, so can revert.)

Before merging, I have two questions:

  • How do you test translations? I tried changing the language of my HA frontend, but didn't notice the translations being used.
  • Since I couldn't verify where the translations are used, I have a couple of doubts about some of the entries (masculine vs feminine, noun vs verb, etc.) How about adding some comments to a reference file (either a separate file, or maybe EN?) giving context for translators?

To overcome the fact that JSON doesn't really support comments, I've used workarounds similar to this in other projects:

{
  "key": "value",
  "#key_comment#": "comment for key"
}

Looking forward to your feedback 馃槃

@mitch-dc mitch-dc merged commit 3d0d28a into mitch-dc:main Feb 27, 2023
@madd0 madd0 deleted the translate branch November 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants