Avoid heavy calls when reading /proc #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple numeric name check should suffice. Otherwise, it is pretty problematic to query processes on systems with SELinux in enforcing mode as it is complicated to open access to _all_ files inside proc. The reason this catch-all access is required is that with os.Readdir it needs to lstat each entry to return os.FileInfo and this requires additional permissions on each disperate file type inside /proc which is not easy to catch with an attribute (as it is with processes).
Update process fetcher to support SELinux-enabled systems.
|
This looks good thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems with SELinux in enforcing mode, this will unnecessarily require broader access to the whole of /proc (
newfstatatorlstatwhich translated to SELinuxgetattrpermission as opposed to a simplegetdents64syscall which is less pervasive).Reading just the names is enough though to determine whether an entry looks like a pid directory.