Should func GetAuth try credentials in the same order as botocore?

[lokulin]

Hi,

Should func GetAuth try credentials in the same order as botocore?

Currently aws.go GetAuth tries:

PackerConfig->Shared->Env->Instance

As seen in

goamz/aws/aws.go

Line 313 in 38665d5

func GetAuth(accessKey string, secretKey string) (auth Auth, err error) {

In contrast, botocore, which the aws-cli tools use tries:

Env->Shared->Config->OriginalEc2->boto->Instance

As seen in: https://github.com/boto/botocore/blob/f93423146eb28e7e0d46aca8929ad16c3d5cf931/botocore/credentials.py#L57

Having Packer check in a different order sometimes causes confusion when users expect the evaluation order to be the same as the official CLI tools.

Cheers,

Lauchlin

[labrute974]

Man, I've had the same issue, I was wondering what it was!

Good one! Hopefully somebody will pick that up quick!

[BertrandLF]

Agreed

[supriyapjoshi]

Sounds good. We should have this fixed.

[lokulin]

@labrute974 @BertrandLF @supriyapjoshi FYI pull request is here:

#172