This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Raise an exception when attempting to insert before an invalid middleware #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builder raises an exception when attempting to insert *after* an invalid middleware, but not before.
|
Yeah the correct solution is probably to add some more checks around everything that requests an index. Good catch. Thanks. :) |
mitchellh
added a commit
that referenced
this pull request
Sep 30, 2012
Raise an exception when attempting to insert before an invalid middleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builder raises an exception when attempting to insert after an invalid middleware, but not before. Note that
#deleteand#replacewould still have inconsistent behavior around this.