This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Use long-hand Hash#slice + Hash#keys instead of Hash#except
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Hash#except` is not in standard Ruby and Vagrant removed `active_support` that provides the polyfill. Resolves mitchellh#566
|
I confirm it works good for me. |
|
Thanks, needed to make a similar patch to my installation of the plugin on a macOS 10.14 host with vagrant 2.2.9 |
mkubenka
added a commit
to mkubenka/vagrant-aws
that referenced
this pull request
Nov 3, 2020
Since Hash#except is not in standard Ruby and Vagrant removed active_support i18n that provides the polyfill in Vagrant 2.2.7; even the polyfill was just Hash#slice minus the requested keys. Seemed simpler to inline than monkey-patch Hash... Resolves mitchellh#566 Based on mitchellh#575
elconde
pushed a commit
to elconde/vagrant-aws
that referenced
this pull request
Nov 30, 2020
LeePorte
pushed a commit
to alphagov/paas-bootstrap
that referenced
this pull request
Feb 15, 2021
We had let this bitrot and it required using an old version of Vagrant. Unfortunatly there is the need to put in a hack due to this issue on the vagrant-aws provider mitchellh/vagrant-aws#566. I suspect that this provider is now abandoned as there is even a PR open to fix it mitchellh/vagrant-aws#575. I propose that we look to remove vagrant in the not too distant future.
LeePorte
pushed a commit
to alphagov/paas-bootstrap
that referenced
this pull request
Feb 16, 2021
We had let this bitrot and it required using an old version of Vagrant. Unfortunatly there is the need to put in a hack due to this issue on the vagrant-aws provider mitchellh/vagrant-aws#566. I suspect that this provider is now abandoned as there is even a PR open to fix it mitchellh/vagrant-aws#575. I propose that we look to remove vagrant in the not too distant future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Hash#exceptis not in standard Ruby and Vagrant removedactive_supporti18nthat provides the polyfill in Vagrant 2.2.7; even the polyfill was justHash#sliceminus the requested keys. Seemed simpler to inline than monkey-patchHash...Resolves #566